Fix: Add RequiredSignatures to the BranchProtectionSettingsUpdate Type#2873
Merged
kfcampbell merged 2 commits intooctokit:mainfrom Feb 5, 2024
wesdevpro:AddRequiredSignatures
Merged
Fix: Add RequiredSignatures to the BranchProtectionSettingsUpdate Type#2873kfcampbell merged 2 commits intooctokit:mainfrom wesdevpro:AddRequiredSignatures
RequiredSignatures to the BranchProtectionSettingsUpdate Type#2873kfcampbell merged 2 commits intooctokit:mainfrom
wesdevpro:AddRequiredSignatures
Conversation
…e` types. - Fixes #2855 - Updated `BranchProtectionSettingsUpdate` by adding `RequiredSignatures`. - Update all integration `xUnit` tests to check for the `RequiredSignatures` property.
kfcampbell
reviewed
Feb 2, 2024
kfcampbell
approved these changes
Feb 5, 2024
This was referenced Jan 24, 2026
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2855
Before the change?
RequiredSignaturesproperty present forBranchProtectionSettingsUpdatetype which is supported by GitHub's rest APIs.After the change?
RequiredSignaturesproperty for theBranchProtectionSettingsUpdatetypeBranchProtectionSettingsUpdatetype to account for the new property (i.eRequiredSignatures)Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!