Skip to content

[feat]: Adding repository variables#2794

Merged
nickfloyd merged 2 commits intooctokit:mainfrom
michaeljolley:repo-variables
Oct 9, 2023
Merged

[feat]: Adding repository variables#2794
nickfloyd merged 2 commits intooctokit:mainfrom
michaeljolley:repo-variables

Conversation

@michaeljolley
Copy link
Contributor

Resolves #2753


Before the change?

No access was provided for repository variables.

After the change?

Adds the ability to:

  • Retrieve repository variables and organization variables assigned to a repository
  • Create new repository variables
  • Update existing repository variables
  • Delete existing repository variables

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@nickfloyd nickfloyd added the Type: Feature New feature or request label Oct 9, 2023
@nickfloyd nickfloyd changed the title Adding repository variables [feat]: Adding repository variables Oct 9, 2023
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @michaeljolley thanks for the contributions here. My only reflection on this was about the Variable object and how it could also be represented as .NET's KeyValuePair. Implemented as is, is totally fine btw - having a concrete representation could be beneficial to serialization and the way we debug log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[FEAT]: Implement variables support

2 participants