Skip to content

[feat] Expose WebCommitSignoffRequired and HasDiscussions for get and update repository objects#2773

Merged
nickfloyd merged 4 commits intooctokit:mainfrom
Syntex9000:main
Sep 22, 2023
Merged

[feat] Expose WebCommitSignoffRequired and HasDiscussions for get and update repository objects#2773
nickfloyd merged 4 commits intooctokit:mainfrom
Syntex9000:main

Conversation

@Syntex9000
Copy link
Contributor

@Syntex9000 Syntex9000 commented Sep 17, 2023

Resolves #2772


Before the change?

  • The WebCommitSignoffRequired and HasDiscussions fields exposed by the REST API are not implemented by octokit.net

After the change?

  • The WebCommitSignoffRequired and HasDiscussions fields will be implemented by octokit.net for the get and update repository objects

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@Syntex9000 Syntex9000 changed the title expose WebCommitSignoffRequired for get and update repository objects Expose WebCommitSignoffRequired and HasDiscussions for get and update repository objects Sep 22, 2023
@nickfloyd nickfloyd added the Type: Feature New feature or request label Sep 22, 2023
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the commits @dirtygooback ❤️

@nickfloyd nickfloyd changed the title Expose WebCommitSignoffRequired and HasDiscussions for get and update repository objects [feat] Expose WebCommitSignoffRequired and HasDiscussions for get and update repository objects Sep 22, 2023
@nickfloyd nickfloyd merged commit 50265be into octokit:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[FEAT]: Add WebCommitSignoffRequired to the Repository get/update objects

2 participants