Fix ActionsSelfHostedRunnersClient Delete Calls#2740
Merged
nickfloyd merged 6 commits intooctokit:mainfrom Jul 5, 2023
Merged
Conversation
nickfloyd
approved these changes
Jul 5, 2023
Contributor
nickfloyd
left a comment
nickfloyd
left a comment
There was a problem hiding this comment.
This LGTM ❤️. Thanks for the 🏕️ work on the comments and descriptions as well.
Lulalaby
referenced
this pull request
in Fortunevale/ProjectMakoto
Jul 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Octokit](https://togithub.com/octokit/octokit.net) | nuget | major | `6.2.1` -> `7.0.1` | --- ### Release Notes <details> <summary>octokit/octokit.net (Octokit)</summary> ### [`v7.0.1`](https://togithub.com/octokit/octokit.net/releases/tag/v7.0.1) #### What's Changed ##### Fixes - Fix ActionsSelfHostedRunnersClient Delete Calls by [@​lineville](https://togithub.com/lineville) in [https://github.com/octokit/octokit.net/pull/2740](https://togithub.com/octokit/octokit.net/pull/2740) ##### Dependencies - build(deps): bump Microsoft.NET.Test.Sdk from 17.6.2 to 17.6.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/octokit/octokit.net/pull/2741](https://togithub.com/octokit/octokit.net/pull/2741) **Full Changelog**: octokit/octokit.net@v7.0.0...v7.0.1 ### [`v7.0.0`](https://togithub.com/octokit/octokit.net/releases/tag/v7.0.0) #### What's Changed ##### Breaking changes - Fix DeploymentStatus IDs Overflowing by [@​Cyberboss](https://togithub.com/Cyberboss) in [https://github.com/octokit/octokit.net/pull/2736](https://togithub.com/octokit/octokit.net/pull/2736) ##### Features - Add Waiting to WorkflowJobStatus by [@​vuryleo](https://togithub.com/vuryleo) in [https://github.com/octokit/octokit.net/pull/2732](https://togithub.com/octokit/octokit.net/pull/2732) #### New Contributors - [@​vuryleo](https://togithub.com/vuryleo) made their first contribution in [https://github.com/octokit/octokit.net/pull/2732](https://togithub.com/octokit/octokit.net/pull/2732) **Full Changelog**: octokit/octokit.net@v6.2.1...v7.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Fortunevale/ProjectMakoto). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=-->
This was referenced Feb 5, 2026
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete___RunnercallsCancellationToken cancellationToken = defaulttoCreate___Tokencalls to allow for an optional cancellation token.Behavior
Before the change?
Delete___Runnermethods would throw an exception caused by passing the wrong kind ofObjectto the underlyingDeletecall. We we're previously passingApiOptionswhich are the wrong type and not relevant.After the change?
Delete___Runnermethods succeed.Create__Tokenmethods allow for passing aCancellationTokenand still succeed.Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance