Skip to content

Add Waiting to WorkflowJobStatus#2732

Merged
kfcampbell merged 2 commits intooctokit:mainfrom
vuryleo:patch-1
Jun 30, 2023
Merged

Add Waiting to WorkflowJobStatus#2732
kfcampbell merged 2 commits intooctokit:mainfrom
vuryleo:patch-1

Conversation

@vuryleo
Copy link
Contributor

@vuryleo vuryleo commented Jun 28, 2023

Resolves #2730


Behavior

Before the change?

After the change?

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@kfcampbell
Copy link
Contributor

Can you share a request that produces the error this PR fixes? Have you tested this with a request that returns a WorkflowJobStatus and validated serialization/deserialization works?

@vuryleo
Copy link
Contributor Author

vuryleo commented Jun 29, 2023

$ curl -H "Authorization: Bearer GITHUB_ACCESS_TOKEN" 'https://[redacted]/api/v3/repos/[redacted]/[redacted]/actions/jobs/[redacted]'  | jq .
{
  "id": [redacted],
  "run_id": [redacted],
  "run_url": "https://[redacted]/api/v3/repos/[redacted]/[redacted]/actions/runs/[redacted]",
  "run_attempt": 1,
  "node_id": "[redacted]",
  "head_sha": "[redacted]",
  "url": "https://[redacted]/api/v3/repos/[redacted]/[redacted]/actions/jobs/[redacted]",
  "html_url": "https://[redacted]/[redacted]/[redacted]/runs/[redacted]?check_suite_focus=true",
  "status": "waiting",
  "conclusion": null,
  "started_at": "2023-06-28T23:03:53Z",
  "completed_at": null,
  "name": "[redacted]",
  "steps": [],
  "check_run_url": "https://[redacted]/api/v3/repos/[redacted]/[redacted]/check-runs/[redacted]",
  "labels": [
    "[redacted]"
  ],
  "runner_id": null,
  "runner_name": null,
  "runner_group_id": null,
  "runner_group_name": null
}

@vuryleo
Copy link
Contributor Author

vuryleo commented Jun 29, 2023

new GitHubClient(new ProductHeaderValue("ph")).Actions.Workflows.Jobs.Get(OrganizationName, RepositoryName, Id)

throws

Newtonsoft.Json.JsonSerializationException

Copy link
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to find a reproducible case for this. Please report back if this solves your issue or additional work is needed!

@kfcampbell kfcampbell merged commit cada8d1 into octokit:main Jun 30, 2023
Lulalaby referenced this pull request in Fortunevale/ProjectMakoto Jul 6, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [Octokit](https://togithub.com/octokit/octokit.net) | nuget | major |
`6.2.1` -> `7.0.1` |

---

### Release Notes

<details>
<summary>octokit/octokit.net (Octokit)</summary>

###
[`v7.0.1`](https://togithub.com/octokit/octokit.net/releases/tag/v7.0.1)

#### What's Changed

##### Fixes

- Fix ActionsSelfHostedRunnersClient Delete Calls by
[@&#8203;lineville](https://togithub.com/lineville) in
[https://github.com/octokit/octokit.net/pull/2740](https://togithub.com/octokit/octokit.net/pull/2740)

##### Dependencies

- build(deps): bump Microsoft.NET.Test.Sdk from 17.6.2 to 17.6.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/octokit/octokit.net/pull/2741](https://togithub.com/octokit/octokit.net/pull/2741)

**Full Changelog**:
octokit/octokit.net@v7.0.0...v7.0.1

###
[`v7.0.0`](https://togithub.com/octokit/octokit.net/releases/tag/v7.0.0)

#### What's Changed

##### Breaking changes

- Fix DeploymentStatus IDs Overflowing by
[@&#8203;Cyberboss](https://togithub.com/Cyberboss) in
[https://github.com/octokit/octokit.net/pull/2736](https://togithub.com/octokit/octokit.net/pull/2736)

##### Features

- Add Waiting to WorkflowJobStatus by
[@&#8203;vuryleo](https://togithub.com/vuryleo) in
[https://github.com/octokit/octokit.net/pull/2732](https://togithub.com/octokit/octokit.net/pull/2732)

#### New Contributors

- [@&#8203;vuryleo](https://togithub.com/vuryleo) made their first
contribution in
[https://github.com/octokit/octokit.net/pull/2732](https://togithub.com/octokit/octokit.net/pull/2732)

**Full Changelog**:
octokit/octokit.net@v6.2.1...v7.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Fortunevale/ProjectMakoto).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: There's no WorkflowJobStatus.Waiting

2 participants