[BUG] Fix Deserializing WorkflowJob#2725
Merged
kfcampbell merged 3 commits intooctokit:mainfrom Jun 16, 2023
Merged
Conversation
1 task
kfcampbell
approved these changes
Jun 16, 2023
Contributor
kfcampbell
left a comment
There was a problem hiding this comment.
Thank you @lineville!
Contributor
Author
|
@kfcampbell Any plans to cut a release anytime soon 😄 ? Is there a plan to try to land a few more PRs before cutting a release? Thanks again for the quick turn around approving and merging this! |
Contributor
|
@lineville I've released v6.1.0; please let me know if your changes aren't properly reflected in that version. |
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2724 by making the following fields nullable:
RunnerId, RunnerName, RunnerGroupId, RunnerGroupNamewhich may be null when the WorkflowJob is coming from aWorkflowJobEventwebhook.Behavior
Before the change?
WorkflowJobEventwebhook would fail if any of the non-nullable fields we're null.After the change?
WorkflowJobEventwebhook succeeds even if it has null values for the 4 fields mentioned above.Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance