Skip to content

Improve repo debugger display#2712

Merged
nickfloyd merged 1 commit intooctokit:mainfrom
martincostello:improve-repo-debugger-display
May 9, 2023
Merged

Improve repo debugger display#2712
nickfloyd merged 1 commit intooctokit:mainfrom
martincostello:improve-repo-debugger-display

Conversation

@martincostello
Copy link
Contributor

Resolves #2711.


Behavior

Before the change?

  • The debugger display string for Repository shows Owner: Octokit.User.

After the change?

  • The debugger display string for Repository shows Owner: {repository owner login}.

Other information

  • N/A

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

Show the repo's owner login in the debugger display string for `Repository` instead of the type name.
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @martincostello ❤️

@nickfloyd nickfloyd added Priority: Normal Type: Feature New feature or request labels May 9, 2023
@nickfloyd nickfloyd merged commit ecf5af4 into octokit:main May 9, 2023
@martincostello martincostello deleted the improve-repo-debugger-display branch May 9, 2023 14:48
Lulalaby referenced this pull request in Fortunevale/ProjectMakoto May 9, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [Octokit](https://togithub.com/octokit/octokit.net) | nuget | major |
`5.1.0` -> `6.0.0` |

---

### Release Notes

<details>
<summary>octokit/octokit.net</summary>

###
[`v6.0.0`](https://togithub.com/octokit/octokit.net/releases/tag/v6.0.0)

#### What's Changed

⚠️ Note this release contains a "low risk" breaking change; see this
[PR](https://togithub.com/octokit/octokit.net/pull/2704) for more
information.

##### Features

- Adds a method to get a single runner group by
[@&#8203;MatisseHack](https://togithub.com/MatisseHack) in
[https://github.com/octokit/octokit.net/pull/2706](https://togithub.com/octokit/octokit.net/pull/2706)
- Improve repo debugger display by
[@&#8203;martincostello](https://togithub.com/martincostello) in
[https://github.com/octokit/octokit.net/pull/2712](https://togithub.com/octokit/octokit.net/pull/2712)
- Adding in support for enterprise audit logs by
[@&#8203;gitasaurus](https://togithub.com/gitasaurus) in
[https://github.com/octokit/octokit.net/pull/2702](https://togithub.com/octokit/octokit.net/pull/2702)

##### Fixes

- \[BREAKING CHANGE] Fix runner application deserialization by
[@&#8203;MatisseHack](https://togithub.com/MatisseHack) in
[https://github.com/octokit/octokit.net/pull/2704](https://togithub.com/octokit/octokit.net/pull/2704)

**Full Changelog**:
https://github.com/octokit/octokit.net/compare/v5.1.0...v6.0.0[](url)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Fortunevale/ProjectMakoto).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43NC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzQuMCIsInRhcmdldEJyYW5jaCI6ImRldiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[FEAT]: Improve debugger display string for Repository model

2 participants