Fix runner application deserialization#2704
Merged
nickfloyd merged 3 commits intooctokit:mainfrom May 9, 2023
Merged
Conversation
nickfloyd
approved these changes
May 9, 2023
Contributor
nickfloyd
left a comment
There was a problem hiding this comment.
Hey @MatisseHack, this change looks good. Thank you for doing it ❤️. I will mark and ship this as a breaking change in light of the type change. Even though it's low risk, bumping major does not cost anything and is a signal in case consumers need to know.
Lulalaby
referenced
this pull request
in Fortunevale/ProjectMakoto
May 9, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Octokit](https://togithub.com/octokit/octokit.net) | nuget | major | `5.1.0` -> `6.0.0` | --- ### Release Notes <details> <summary>octokit/octokit.net</summary> ### [`v6.0.0`](https://togithub.com/octokit/octokit.net/releases/tag/v6.0.0) #### What's Changed⚠️ Note this release contains a "low risk" breaking change; see this [PR](https://togithub.com/octokit/octokit.net/pull/2704) for more information. ##### Features - Adds a method to get a single runner group by [@​MatisseHack](https://togithub.com/MatisseHack) in [https://github.com/octokit/octokit.net/pull/2706](https://togithub.com/octokit/octokit.net/pull/2706) - Improve repo debugger display by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/octokit/octokit.net/pull/2712](https://togithub.com/octokit/octokit.net/pull/2712) - Adding in support for enterprise audit logs by [@​gitasaurus](https://togithub.com/gitasaurus) in [https://github.com/octokit/octokit.net/pull/2702](https://togithub.com/octokit/octokit.net/pull/2702) ##### Fixes - \[BREAKING CHANGE] Fix runner application deserialization by [@​MatisseHack](https://togithub.com/MatisseHack) in [https://github.com/octokit/octokit.net/pull/2704](https://togithub.com/octokit/octokit.net/pull/2704) **Full Changelog**: https://github.com/octokit/octokit.net/compare/v5.1.0...v6.0.0[](url) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Fortunevale/ProjectMakoto). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43NC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzQuMCIsInRhcmdldEJyYW5jaCI6ImRldiJ9-->
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2703
Behavior
Before the change?
ListAllRunnerApplicationsForOrganizationin theActionsSelfHostedRunnersClientAfter the change?
Other information
I fixed the issue by removing the extra
IReadOnlyListlayer sinceApiConnection.GetAllalready returns anIReadOnlyList. I also made a few other updates to theRunnerApplicationmodel:RunnerLabelmodel since theLabelmodel is for issue/PR labels and didn't match the properties in the JSON payloadAdditional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Bugfix
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance