Adding in support for enterprise audit logs#2702
Adding in support for enterprise audit logs#2702nickfloyd merged 7 commits intooctokit:mainfrom gitasaurus:EnterpriseAuditLogs
Conversation
|
@kfcampbell , do you have any guidance on fixing ApiConnectionTests+TheGetAllMethod? |
|
@gitasaurus I'm currently struggling to reproduce this locally. Running unit tests using |
|
Thanks for looking at this. I will update this pull request tomorrow. I found that the paging for Audit Logs does not work the same as the other APIs. I have added a way to address that. Please hold off on approving this until then. |
|
@kfcampbell, this change added in the ability to stop retrieving Audit Logs when a search string is found (e.g. a document id or timestamp), allowing users to retrieve the latest log until they encounter a known log. |
|
👍, although the build is still failing so I can't approve/merge until that's set. |
|
@kfcampbell , fixed the failing tests. |
nickfloyd
left a comment
There was a problem hiding this comment.
@gitasaurus Thanks for adding this feature here! ❤️
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Octokit](https://togithub.com/octokit/octokit.net) | nuget | major | `5.1.0` -> `6.0.0` | --- ### Release Notes <details> <summary>octokit/octokit.net</summary> ### [`v6.0.0`](https://togithub.com/octokit/octokit.net/releases/tag/v6.0.0) #### What's Changed⚠️ Note this release contains a "low risk" breaking change; see this [PR](https://togithub.com/octokit/octokit.net/pull/2704) for more information. ##### Features - Adds a method to get a single runner group by [@​MatisseHack](https://togithub.com/MatisseHack) in [https://github.com/octokit/octokit.net/pull/2706](https://togithub.com/octokit/octokit.net/pull/2706) - Improve repo debugger display by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/octokit/octokit.net/pull/2712](https://togithub.com/octokit/octokit.net/pull/2712) - Adding in support for enterprise audit logs by [@​gitasaurus](https://togithub.com/gitasaurus) in [https://github.com/octokit/octokit.net/pull/2702](https://togithub.com/octokit/octokit.net/pull/2702) ##### Fixes - \[BREAKING CHANGE] Fix runner application deserialization by [@​MatisseHack](https://togithub.com/MatisseHack) in [https://github.com/octokit/octokit.net/pull/2704](https://togithub.com/octokit/octokit.net/pull/2704) **Full Changelog**: https://github.com/octokit/octokit.net/compare/v5.1.0...v6.0.0[](url) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Fortunevale/ProjectMakoto). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43NC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzQuMCIsInRhcmdldEJyYW5jaCI6ImRldiJ9-->
Resolves #2701
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance