Skip to content

Adding in support for enterprise audit logs#2702

Merged
nickfloyd merged 7 commits intooctokit:mainfrom
gitasaurus:EnterpriseAuditLogs
May 9, 2023
Merged

Adding in support for enterprise audit logs#2702
nickfloyd merged 7 commits intooctokit:mainfrom
gitasaurus:EnterpriseAuditLogs

Conversation

@gitasaurus
Copy link
Contributor

@gitasaurus gitasaurus commented Apr 21, 2023

Resolves #2701


Behavior

Before the change?

After the change?

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@gitasaurus
Copy link
Contributor Author

@kfcampbell , do you have any guidance on fixing ApiConnectionTests+TheGetAllMethod?

@kfcampbell
Copy link
Contributor

@gitasaurus I'm currently struggling to reproduce this locally. Running unit tests using dotnet test is passing for me on .NET 7.0.102. I'm not sure if it's failing using .NET 5 or .NET 6 during this test, though perhaps we should think about removing .NET 5 testing as it's reached end-of-life.

@gitasaurus
Copy link
Contributor Author

Thanks for looking at this. I will update this pull request tomorrow. I found that the paging for Audit Logs does not work the same as the other APIs. I have added a way to address that. Please hold off on approving this until then.

@gitasaurus
Copy link
Contributor Author

@kfcampbell, this change added in the ability to stop retrieving Audit Logs when a search string is found (e.g. a document id or timestamp), allowing users to retrieve the latest log until they encounter a known log.

@kfcampbell
Copy link
Contributor

👍, although the build is still failing so I can't approve/merge until that's set.

@gitasaurus
Copy link
Contributor Author

@kfcampbell , fixed the failing tests.

@nickfloyd nickfloyd added Priority: Normal Type: Feature New feature or request labels May 9, 2023
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitasaurus Thanks for adding this feature here! ❤️

@nickfloyd nickfloyd merged commit 3c82ff3 into octokit:main May 9, 2023
Lulalaby referenced this pull request in Fortunevale/ProjectMakoto May 9, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [Octokit](https://togithub.com/octokit/octokit.net) | nuget | major |
`5.1.0` -> `6.0.0` |

---

### Release Notes

<details>
<summary>octokit/octokit.net</summary>

###
[`v6.0.0`](https://togithub.com/octokit/octokit.net/releases/tag/v6.0.0)

#### What's Changed

⚠️ Note this release contains a "low risk" breaking change; see this
[PR](https://togithub.com/octokit/octokit.net/pull/2704) for more
information.

##### Features

- Adds a method to get a single runner group by
[@&#8203;MatisseHack](https://togithub.com/MatisseHack) in
[https://github.com/octokit/octokit.net/pull/2706](https://togithub.com/octokit/octokit.net/pull/2706)
- Improve repo debugger display by
[@&#8203;martincostello](https://togithub.com/martincostello) in
[https://github.com/octokit/octokit.net/pull/2712](https://togithub.com/octokit/octokit.net/pull/2712)
- Adding in support for enterprise audit logs by
[@&#8203;gitasaurus](https://togithub.com/gitasaurus) in
[https://github.com/octokit/octokit.net/pull/2702](https://togithub.com/octokit/octokit.net/pull/2702)

##### Fixes

- \[BREAKING CHANGE] Fix runner application deserialization by
[@&#8203;MatisseHack](https://togithub.com/MatisseHack) in
[https://github.com/octokit/octokit.net/pull/2704](https://togithub.com/octokit/octokit.net/pull/2704)

**Full Changelog**:
https://github.com/octokit/octokit.net/compare/v5.1.0...v6.0.0[](url)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Fortunevale/ProjectMakoto).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43NC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzQuMCIsInRhcmdldEJyYW5jaCI6ImRldiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[FEAT]: Support for the Enterprise Audit Log

3 participants