[FEAT] Self-hosted runners and Self-hosted runner groups APIs by lineville · Pull Request #2695 · octokit/octokit.net

lineville · 2023-04-07T00:41:04Z

Resolves #2692 by implementing support for the following API's

Self-Hosted Runners

Self-Hosted Runner Groups

List self-hosted runner groups for an enterprise
List self-hosted runner groups for an organization
List organization access to a self-hosted runner group in an enterprise
List repository access to a self-hosted runner group in an organization

Behavior

Before the change?

The ActionsSelfHostedRunnersClient and ActionsSelfHostedRunnerGroupsClient we're empty and not implemented

After the change?

The ActionsSelfHostedRunnersClient and ActionsSelfHostedRunnerGroupsClient have been implemented (non-exhaustively) to include several of the available API's (listed above)

Other information

Models that we're added include Runner, RunnerResponse, RunnerApplication and RunnerApplicationResponse
There are many APIs under the Self-Hosted Runner and Self-Hosted Runner Groups that are left unimplemented after this PR

Additional info

Pull request checklist

Tests for the changes have been added (for bug fixes / features)
Docs have been reviewed and added / updated if needed (for bug fixes / features)
Added the appropriate label for the given change

☝️ Unable to add labels to the PR 😕 but should be tagged with feature

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

Yes (Please add the Type: Breaking change label)
No

If Yes, what's the impact:

N/A

Pull request type

Please add the corresponding label for change this PR introduces:

Bugfix: Type: Bug
Feature/model/API additions: Type: Feature
Updates to docs or samples: Type: Documentation
Dependencies/code cleanup: Type: Maintenance

kfcampbell · 2023-04-17T20:25:22Z

@lineville is this still something you're interested in getting in?

lineville · 2023-04-17T21:45:44Z

@lineville is this still something you're interested in getting in?

Yes, I'd love to get this in. I have been working on adding some integration tests. I have been facing some issues with authenticating given that some of the tests need to access an enterprise etc. Unit tests and Convention tests and docs are done ✅, was just trying to finish up some integration tests, or at least validate somehow it's functional end to end before opening this PR up for review.

@kfcampbell If you have any ideas about running integration tests against an enterprise, or any details you might have about how the existing integration tests are run locally or in CI would be super helpful 🙇

kfcampbell · 2023-04-17T22:27:24Z

As far as I'm aware, this the only script used in our automated checks, which runs unit tests but not any integration tests. I think we'd be working from scratch with enterprise integration testing.

lineville · 2023-04-17T22:55:08Z

@kfcampbell Thanks! I won't worry too much about having exhaustive integration tests then, given that it's not run in CI anyways. I'll open this PR up for review shortly!

lineville · 2023-04-18T18:56:25Z

@kfcampbell I've pushed up some final changes and opened this up for review! No rush or anything, but just curious what the release cadence looks like for this project? Are you planning to cut a release sometime soon?

kfcampbell · 2023-04-20T22:34:13Z

@lineville release cadence is ad-hoc depending on PRs that have been merged. When this goes in, we can cut a release shortly thereafter.

lineville · 2023-04-26T17:52:37Z

@kfcampbell Just bumping this 😄, any ideas when we could expect this to be merged and released? Is there anything from my end that might be holding this up?

nickfloyd

This looks great! Thank you for the changes ❤️

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Octokit](https://togithub.com/octokit/octokit.net) | nuget | minor | `5.0.4` -> `5.1.0` | --- ### Release Notes <details> <summary>octokit/octokit.net</summary> ### [`v5.1.0`](https://togithub.com/octokit/octokit.net/releases/tag/v5.1.0) #### What's Changed ##### Features - Allow users to fetch all commits for two commits comparison by [@zolroman](https://togithub.com/zolroman) in [https://github.com/octokit/octokit.net/pull/2690](https://togithub.com/octokit/octokit.net/pull/2690) - Added missing 'container' property in metadata on a package version. by [@thomaslem](https://togithub.com/thomaslem) in [https://github.com/octokit/octokit.net/pull/2696](https://togithub.com/octokit/octokit.net/pull/2696) - Self-hosted runners and Self-hosted runner groups APIs by [@lineville](https://togithub.com/lineville) in [https://github.com/octokit/octokit.net/pull/2695](https://togithub.com/octokit/octokit.net/pull/2695) ##### Fixes - Removing empty object parameter in MigrationsClient.DeleteArchive by [@gitasaurus](https://togithub.com/gitasaurus) in [https://github.com/octokit/octokit.net/pull/2698](https://togithub.com/octokit/octokit.net/pull/2698) #### New Contributors - [@zolroman](https://togithub.com/zolroman) made their first contribution in [https://github.com/octokit/octokit.net/pull/2690](https://togithub.com/octokit/octokit.net/pull/2690) - [@thomaslem](https://togithub.com/thomaslem) made their first contribution in [https://github.com/octokit/octokit.net/pull/2696](https://togithub.com/octokit/octokit.net/pull/2696) - [@gitasaurus](https://togithub.com/gitasaurus) made their first contribution in [https://github.com/octokit/octokit.net/pull/2698](https://togithub.com/octokit/octokit.net/pull/2698) - [@lineville](https://togithub.com/lineville) made their first contribution in [https://github.com/octokit/octokit.net/pull/2695](https://togithub.com/octokit/octokit.net/pull/2695) **Full Changelog**: octokit/octokit.net@v5.0.4...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Fortunevale/ProjectMakoto).

lineville added 6 commits April 4, 2023 18:45

wip

a66404e

wip

c32bf9d

wip

1312fec

wip conventions met

86710b2

fix spec

514b107

wip

d547c6c

lineville changed the title ~~Self hosted runners apis~~ [FEAT] Self-hosted runners and Self-hosted runner groups SPIs Apr 7, 2023

lineville changed the title ~~[FEAT] Self-hosted runners and Self-hosted runner groups SPIs~~ [FEAT] Self-hosted runners and Self-hosted runner groups APIs Apr 7, 2023

lineville added 18 commits April 6, 2023 21:04

self-hosted runners ✅

6a07ca4

add tests

00d1691

wip runner group client ✅

a3e4543

add reactives

bb4e3d3

Update netcore.yml

0f5a1a1

Update netcore.yml

a8da3b1

Update netcore.yml

f73bb21

Update netcore.yml

537a6a7

formatting

20daeab

updates using connection

22f67a2

Update netcore.yml

dbac672

wip

9bd5b9f

wip

b4424f4

wip

3582849

wip conventions met

9aa8d9b

wip

eb9c4ff

refactor add docs

4988dd9

revert wf

c288564

wip

22ca1e9

lineville added 2 commits April 17, 2023 15:57

remove int tests

cdf4d62

Merge branch 'main' into self-hosted-runners-apis

3d46dcf

lineville marked this pull request as ready for review April 17, 2023 23:01

fix warning

acda62a

nickfloyd approved these changes Apr 28, 2023

View reviewed changes

nickfloyd merged commit 2d4ba4e into octokit:main Apr 28, 2023

This was referenced Feb 5, 2026

Bump Octokit from 0.48.0 to 14.0.0 Harshad811/demoproject#108

Open

Bump Octokit from 0.48.0 to 14.0.0 Harshad811/demoproject#114

Open

dependabot bot mentioned this pull request Feb 26, 2026

Bump Octokit from 4.0.1 to 14.0.0 step-security/edit-release#10

Open

dependabot bot mentioned this pull request Mar 18, 2026

Bump Octokit from 4.0.1 to 14.0.0 actions-marketplace-validations/irongut_EditRelease#24

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEAT] Self-hosted runners and Self-hosted runner groups APIs#2695

[FEAT] Self-hosted runners and Self-hosted runner groups APIs#2695
nickfloyd merged 28 commits intooctokit:mainfrom
lineville:self-hosted-runners-apis

lineville commented Apr 7, 2023 •

edited

Loading

Uh oh!

kfcampbell commented Apr 17, 2023

Uh oh!

lineville commented Apr 17, 2023

Uh oh!

kfcampbell commented Apr 17, 2023

Uh oh!

lineville commented Apr 17, 2023

Uh oh!

lineville commented Apr 18, 2023

Uh oh!

kfcampbell commented Apr 20, 2023

Uh oh!

lineville commented Apr 26, 2023

Uh oh!

nickfloyd left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lineville commented Apr 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Self-Hosted Runners

Self-Hosted Runner Groups

Behavior

Before the change?

After the change?

Other information

Additional info

Pull request checklist

Does this introduce a breaking change?

Pull request type

Uh oh!

kfcampbell commented Apr 17, 2023

Uh oh!

lineville commented Apr 17, 2023

Uh oh!

kfcampbell commented Apr 17, 2023

Uh oh!

lineville commented Apr 17, 2023

Uh oh!

lineville commented Apr 18, 2023

Uh oh!

kfcampbell commented Apr 20, 2023

Uh oh!

lineville commented Apr 26, 2023

Uh oh!

nickfloyd left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lineville commented Apr 7, 2023 •

edited

Loading