Skip to content

Add missing workflow run conclusions#2685

Merged
nickfloyd merged 1 commit intooctokit:mainfrom
ezhevita:ezhevita/add-missing-run-conclusions
Mar 24, 2023
Merged

Add missing workflow run conclusions#2685
nickfloyd merged 1 commit intooctokit:mainfrom
ezhevita:ezhevita/add-missing-run-conclusions

Conversation

@ezhevita
Copy link
Contributor

@ezhevita ezhevita commented Mar 19, 2023

Resolves #2684


Behavior

Before the change?

  • The property to get a workflow run conclusion throws an exception when trying to get value of the workflow run with the conclusion of startup_failure or skipped.

After the change?

  • The property returns the workflow run conclusion correctly and doesn't throw an exception.

Other information

  • I've mentioned in the original issue that GitHub documentation doesn't include these values as well, so it will be great if you pass this information internally to the docs team 😄

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@ezhevita
Copy link
Contributor Author

also GitHub doesn't seem to allow me to add a label to the PR, so if someone adds it for me I'll be happy 😁
the appropriate label is Type: Bug

@nickfloyd nickfloyd added Priority: Normal Type: Feature New feature or request labels Mar 24, 2023
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ezhevita, Thanks for the work here ❤️ . We're still chatting about the API docs and the need for the enum values to be surfaced in a more visible way but this change is a solid addition to the SDK, thanks again for doing it!

@nickfloyd nickfloyd merged commit 7349ecd into octokit:main Mar 24, 2023
@ezhevita ezhevita deleted the ezhevita/add-missing-run-conclusions branch March 25, 2023 15:46
Lulalaby referenced this pull request in Fortunevale/ProjectMakoto Apr 15, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [Octokit](https://togithub.com/octokit/octokit.net) | nuget | patch |
`5.0.2` -> `5.0.4` |

---

### Release Notes

<details>
<summary>octokit/octokit.net</summary>

###
[`v5.0.4`](https://togithub.com/octokit/octokit.net/releases/tag/v5.0.4)

#### What's Changed

- Added Mannequin account type for migrated repos by
[@&#8203;MGbiorczyk95](https://togithub.com/MGbiorczyk95) in
[https://github.com/octokit/octokit.net/pull/2694](https://togithub.com/octokit/octokit.net/pull/2694)

#### New Contributors

- [@&#8203;MGbiorczyk95](https://togithub.com/MGbiorczyk95) made their
first contribution in
[https://github.com/octokit/octokit.net/pull/2694](https://togithub.com/octokit/octokit.net/pull/2694)

**Full Changelog**:
octokit/octokit.net@v5.0.3...v5.1.0

###
[`v5.0.3`](https://togithub.com/octokit/octokit.net/releases/tag/v5.0.3)

#### What's Changed

##### Features

- Add missing workflow run conclusions by
[@&#8203;ezhevita](https://togithub.com/ezhevita) in
[https://github.com/octokit/octokit.net/pull/2685](https://togithub.com/octokit/octokit.net/pull/2685)

##### Maintenance

- build(deps): bump GitHubJwt from 0.0.5 to 0.0.6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/octokit/octokit.net/pull/2691](https://togithub.com/octokit/octokit.net/pull/2691)

#### New Contributors

- [@&#8203;ezhevita](https://togithub.com/ezhevita) made their first
contribution in
[https://github.com/octokit/octokit.net/pull/2685](https://togithub.com/octokit/octokit.net/pull/2685)

**Full Changelog**:
octokit/octokit.net@v5.0.2...v5.0.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Fortunevale/ProjectMakoto).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: Missing workflow run conclusions

2 participants