Correctly deserialize CollaboratorPermissionResponse#2682
Merged
nickfloyd merged 1 commit intooctokit:mainfrom Mar 10, 2023
Merged
Correctly deserialize CollaboratorPermissionResponse#2682nickfloyd merged 1 commit intooctokit:mainfrom
nickfloyd merged 1 commit intooctokit:mainfrom
Conversation
Contributor
Author
|
/cc @JimSuplizio |
Contributor
|
Hey @heaths, I am taking a look at this now... thank you for jumping on this so quickly. I missed it in my review the other day; apologies for that oversight! ❤️ |
nickfloyd
approved these changes
Mar 10, 2023
Contributor
nickfloyd
left a comment
nickfloyd
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the going the extra mile with tests and a fixture ❤️
Contributor
Author
|
Might we see a 5.1.1 in the near-ish future? For now we used the legacy /cc @JimSuplizio who is working on incorporating this new version into our bot. |
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2681