Skip to content

build(deps): bump NSubstitute from 4.4.0 to 5.0.0#2669

Merged
nickfloyd merged 3 commits intomainfrom
dependabot/nuget/NSubstitute-5.0.0
Mar 9, 2023
Merged

build(deps): bump NSubstitute from 4.4.0 to 5.0.0#2669
nickfloyd merged 3 commits intomainfrom
dependabot/nuget/NSubstitute-5.0.0

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 13, 2023

Bumps NSubstitute from 4.4.0 to 5.0.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps NSubstitute from 4.4.0 to 5.0.0.

---
updated-dependencies:
- dependency-name: NSubstitute
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 13, 2023
@kfcampbell
Copy link
Contributor

The release notes for NSubstitute mention that minimum versions supported are now .NET 6+, .NET Framework 4.6.2+, and .NET Standard 2.0+.

Our supported platforms are .NET 4.6.1+ and .NET Standard 2.0+.

This means Octokit.net supports .NET 4.6.1 and NSubstitute doesn't. If we're comfortable changing our supported version (or are comfortable with taking on a test dependency that supports a different platform) we may merge this PR.

@nickfloyd
Copy link
Contributor

@kfcampbell As a follow-up, I updated every lib to be .NET standard 2.0 a few months ago - which makes this a valid change… we might need to update some docs somewhere… but I believe this change should be g2g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants