Skip to content

Add missing properties to IssueEvent.#2585

Merged
kfcampbell merged 3 commits intooctokit:mainfrom
bloslo:issue_event_missing_properties
Oct 19, 2022
Merged

Add missing properties to IssueEvent.#2585
kfcampbell merged 3 commits intooctokit:mainfrom
bloslo:issue_event_missing_properties

Conversation

@bloslo
Copy link
Contributor

@bloslo bloslo commented Oct 1, 2022

Fixes #2550.

Copy link
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to ourselves to bump the minor version of octokit.net when releasing this PR. Although the constructor changes to IssueEvent are technically breaking, the model is used internally in Octokit and this shouldn't cause practical issues for users.

@kfcampbell
Copy link
Contributor

The checks weren't showing until I merged in the latest main, which is interesting. I think this is good to go now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IssueEvent is missing payload for code review set of events

3 participants