Skip to content

Splitting out the misc client into separate clients as per current documentation#2574

Merged
nickfloyd merged 2 commits intooctokit:mainfrom
JonruAlveus:2572_SplitMiscClient
Sep 20, 2022
Merged

Splitting out the misc client into separate clients as per current documentation#2574
nickfloyd merged 2 commits intooctokit:mainfrom
JonruAlveus:2572_SplitMiscClient

Conversation

@JonruAlveus
Copy link
Contributor

Splitting out Miscellaneous client into new clients.

  1. Split clients and interfaces
  2. Redirect misc client to new interfaces
  3. Obsolete methods with descriptions
  4. Repeat for Observable
  5. Duplicate unit tests
  6. Duplicate integration tests

@JonruAlveus
Copy link
Contributor Author

@SeanKilleen @timrogers @nickfloyd I've made a start, let me know if there's anything glaring (the build will likely fail but I've gotta go!).

@JonruAlveus
Copy link
Contributor Author

All done. Emojis and Meta endpoints didn't work before and don't work now, that can be dealt with separately. I believe Emojis already has a PR but might need to be done again.

@SeanKilleen
Copy link
Contributor

@JonruAlveus probably makes sense to file an additional issue about emoji and meta endpoints not working and why. 👍 Nice work on this!

@JonruAlveus JonruAlveus changed the title WIP Splitting out the misc client into separate clients as per current documentation Splitting out the misc client into separate clients as per current documentation Sep 17, 2022
@JonruAlveus
Copy link
Contributor Author

Thanks @SeanKilleen, I have both raised issues and PRs :)

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this knocked out! 🎉

@nickfloyd nickfloyd merged commit 3c05db4 into octokit:main Sep 20, 2022
@nickfloyd
Copy link
Contributor

release_notes: Splits out the misc client into separate clients as per current documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants