Skip to content

Remove /en slug in docs.github.com links (and stop VSCode from formatting on save)#2573

Merged
nickfloyd merged 2 commits intooctokit:mainfrom
SeanKilleen:remove-en-slug
Sep 20, 2022
Merged

Remove /en slug in docs.github.com links (and stop VSCode from formatting on save)#2573
nickfloyd merged 2 commits intooctokit:mainfrom
SeanKilleen:remove-en-slug

Conversation

@SeanKilleen
Copy link
Contributor

Supports #2474

  • Updates vs code settings file to stop format on save
  • Removes /en from the existing docs.github.com links

@SeanKilleen
Copy link
Contributor Author

@nickfloyd here's a smaller, targeted PR to start us off. Ready for review.

Copy link
Contributor

@JonruAlveus JonruAlveus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@nickfloyd nickfloyd merged commit 05aa951 into octokit:main Sep 20, 2022
@nickfloyd
Copy link
Contributor

release_notes: Removes /en slug in docs.github.com links (and stop VSCode from formatting on save)

@nickfloyd
Copy link
Contributor

Thanks for taking this on and getting things started with docs here @SeanKilleen! You're a 🦸!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants