Skip to content

Add ability to pass ApiOptions to PullRequestsClient.Files#2553

Merged
JonruAlveus merged 2 commits intooctokit:mainfrom
Gamer025:PRFiles_ApiOptions
Aug 28, 2022
Merged

Add ability to pass ApiOptions to PullRequestsClient.Files#2553
JonruAlveus merged 2 commits intooctokit:mainfrom
Gamer025:PRFiles_ApiOptions

Conversation

@Gamer025
Copy link
Contributor

This fixes #2552 by allowing you to pass an ApiOptions object to the Files method of PullRequestsClient.
Files can still be called without ApiOptions and will simply pass on ApiOptions.None then.

Copy link
Contributor

@timrogers timrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the time to contribute to Octokit! I really appreciate it ✨ This looks good to me - but I'm not a .NET expert by any means. Before we merge, I'd love @nickfloyd (currently on vacation) or @JonruAlveus to review as well.

@timrogers
Copy link
Contributor

Fixes #2552.

Copy link
Contributor

@JonruAlveus JonruAlveus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ⭐️

@JonruAlveus JonruAlveus merged commit 498c2aa into octokit:main Aug 28, 2022
@Gamer025 Gamer025 deleted the PRFiles_ApiOptions branch August 31, 2022 17:10
@nickfloyd
Copy link
Contributor

release_notes: Adds the ability to pass ApiOptions to PullRequestsClient.Files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to specify per_page for PullRequest.Files?

4 participants