Fixing a number of warnings for a cleaner build#2529
Conversation
nickfloyd
left a comment
nickfloyd
left a comment
There was a problem hiding this comment.
Good stuff @JonruAlveus, just a couple of text changes where the comment notation seems off!
Octokit/Helpers/ApiUrls.cs
Outdated
| /// </summary> | ||
| /// <param name="repositoryId">The Id of the repository</param> | ||
| /// <param name="number">The issue number</param> | ||
| /// /// <param name="reaction">The reactionid for the issue</param> |
There was a problem hiding this comment.
| /// /// <param name="reaction">The reactionid for the issue</param> | |
| /// <param name="reaction">The reactionid for the issue</param> |
Octokit/Helpers/ApiUrls.cs
Outdated
| /// <param name="owner">The owner of the repository</param> | ||
| /// <param name="name">The name of the repository</param> | ||
| /// <param name="number">The comment number</param> | ||
| /// /// <param name="reaction">The reactionid for the comment</param> |
There was a problem hiding this comment.
| /// /// <param name="reaction">The reactionid for the comment</param> | |
| /// <param name="reaction">The reactionid for the comment</param> |
| AllowSquashMerge = allowSquashMerge; | ||
| AllowMergeCommit = allowMergeCommit; | ||
| Archived = archived; | ||
| #pragma warning disable CS0618 // Type or member is obsolete |
There was a problem hiding this comment.
I like this approach much better than throwing warns.. this feels like a ubiquitous language kinda thing as well; as in we need a common comment language to communicate things such as obsolete fields, etc... so that we can set up automation or simply search when we decided to clean things up.
There was a problem hiding this comment.
Definitely. Obsoletes should really be there for people trying to use the codebase we produce. If we're obsoleting something, we should really change it locally so we don't use it any more, before packaging it up etc.
Yes, definitely we need some common language, it could get very messy otherwise!
|
part of #2496 |
|
release_notes: Cleaned up build warnings |
nickfloyd
added
Type: Maintenance
2 participants
I tried to also work out why the net462 tests fail on binary deserialization, but I couldn't. One for another time.