Skip to content

Adding more properties to get and update methods and fixing failing i…#2485

Merged
nickfloyd merged 1 commit intooctokit:mainfrom
JonruAlveus:2465-Extend_Branch_Protection_Api
Jul 15, 2022
Merged

Adding more properties to get and update methods and fixing failing i…#2485
nickfloyd merged 1 commit intooctokit:mainfrom
JonruAlveus:2465-Extend_Branch_Protection_Api

Conversation

@JonruAlveus
Copy link
Contributor

Fixes #2465

Adding more properties to get and update methods and fixing failing integration tests

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for getting the knocked out!

/// Status check settings for the protected branch
/// </summary>
public BranchProtectionRequiredStatusChecks RequiredStatusChecks { get; protected set; }
public BranchProtectionRequiredStatusChecks RequiredStatusChecks { get; private set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the clean-up here! 🎉

@nickfloyd nickfloyd merged commit 5cf604b into octokit:main Jul 15, 2022
@nickfloyd
Copy link
Contributor

release_notes: Adds missing properties to the branch protection response object

@JonruAlveus JonruAlveus deleted the 2465-Extend_Branch_Protection_Api branch July 21, 2022 04:41
@nickfloyd nickfloyd added Type: Feature New feature or request and removed category: feature labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing response properties on the branch protection api

2 participants