Skip to content

Use the official Codespaces template configuration, rather than something homegrown#2449

Merged
timrogers merged 3 commits intomainfrom
timrogers/devcontainer-v2
May 19, 2022
Merged

Use the official Codespaces template configuration, rather than something homegrown#2449
timrogers merged 3 commits intomainfrom
timrogers/devcontainer-v2

Conversation

@timrogers
Copy link
Contributor

This switches our Codespaces setup to use a more standard one based on the official microsoft/vscode-dev-containers configuration.

Hello!
@timrogers timrogers requested a review from nickfloyd May 18, 2022 15:07
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this ❤️ ! Just one minor ask around some formatting - for consistency sake in devcontainer.json

Let me know if you have any questions.

@nickfloyd nickfloyd assigned nickfloyd and timrogers and unassigned nickfloyd May 18, 2022
@timrogers timrogers force-pushed the timrogers/devcontainer-v2 branch from 46b8d97 to 4e85762 Compare May 18, 2022 17:35
@timrogers timrogers requested a review from nickfloyd May 18, 2022 17:35
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I can't wait to make use of this in local iterations! Thank you ❤️

@timrogers timrogers merged commit 727029c into main May 19, 2022
@timrogers timrogers deleted the timrogers/devcontainer-v2 branch May 19, 2022 08:48
@nickfloyd
Copy link
Contributor

release_notes: Adds Codespaces template configuration for the dev container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants