Skip to content

Update permissions based on GitHub documentation#2424

Merged
nickfloyd merged 1 commit intooctokit:mainfrom
samvdd-247:patch-1
Jul 11, 2022
Merged

Update permissions based on GitHub documentation#2424
nickfloyd merged 1 commit intooctokit:mainfrom
samvdd-247:patch-1

Conversation

@samvdd-247
Copy link
Contributor

Added the following permissions maintain and triage based on the GitHub documentation

https://docs.github.com/en/rest/reference/teams#add-or-update-team-repository-permissions

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samvdd-247 Apologies for the delay in getting to this and thank you for this change ❤️! Would you mind adding push as well? I know it's the default value if none is provided but it would be nice to have a complete representation of the API contract here.

If you don't have time, no worries, I'd be glad to do it after this gets merged if needed.

@samvdd-247
Copy link
Contributor Author

@nickfloyd the "push" permission was already there so nothing needs to be added

@samvdd-247
Copy link
Contributor Author

Added the following permissions maintain and triage based on the GitHub documentation

https://docs.github.com/en/rest/reference/teams#add-or-update-team-repository-permissions

@samvdd-247 samvdd-247 closed this Jul 11, 2022
@samvdd-247 samvdd-247 reopened this Jul 11, 2022
@samvdd-247 samvdd-247 closed this Jul 11, 2022
@samvdd-247 samvdd-247 reopened this Jul 11, 2022
@nickfloyd nickfloyd merged commit f6e541d into octokit:main Jul 11, 2022
@samvdd-247 samvdd-247 deleted the patch-1 branch July 12, 2022 06:16
@nickfloyd
Copy link
Contributor

release_notes: Adds new permissions to the team repository permissions enum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants