Support for IsTemplate and Create Template from Repository#2331
Support for IsTemplate and Create Template from Repository#2331nickfloyd merged 4 commits intooctokit:mainfrom JonruAlveus:repository_templates
Conversation
…bility to create repositories from a template. Most code taken from FrediKats PR 2187 with fixed tests. Beptiste preview tag added to all repository endpoints mentioned in the GitHub Api documentation.
JonruAlveus
changed the title
|
🙌 |
|
@shiftkey Please could you have a review of this pr? |
shiftkey
left a comment
shiftkey
left a comment
There was a problem hiding this comment.
Changes look good, just missing some docs for the new endpoint
| /// </summary> | ||
| /// <param name="templateOwner">The owner of the template</param> | ||
| /// <param name="templateRepo">The name of the template</param> | ||
| /// <param name="newRepository"></param> |
There was a problem hiding this comment.
📝 please document this new parameter
There was a problem hiding this comment.
Documentation added
| /// </summary> | ||
| /// <param name="templateOwner">The organization or person who will owns the template</param> | ||
| /// <param name="templateRepo">The name of template repository to work from</param> | ||
| /// <param name="newRepository"></param> |
There was a problem hiding this comment.
📝 please document this new parameter
There was a problem hiding this comment.
Documentation added
|
@shiftkey can we please merge this one ? much needed, thanks |
|
@shiftkey Will we ever get these changes? I'm waiting on this as well. |
|
As a temporary workaround I’ve found that you can either get hold of the http client or there is a way to perform a Get directly in the client. So you can do the equivalent of this without having to code it all/wait for the pr. If anyone needs it I’ll try to find an example. |
|
I'm no longer a maintainer of this project, cc @nickfloyd for visibility |
nickfloyd
left a comment
nickfloyd
left a comment
There was a problem hiding this comment.
Hey @JonruAlveus, et. al apologize for the massive delay on this, and thank you for taking the time to make these changes. They all LGTM ✅ .
|
@JonruAlveus, @emmielewisbriggman, @ihorbond, and @tomkerkhove I'm planning on shipping this change tomorrow. Thank you for your contributions and your patience. |
|
No problem. I am just using the API using httpclient for now. |
|
release_notes: Adds support for IsTemplate and Create Template from Repository |
nickfloyd
added
Type: Feature
6 participants
Fixes #2148
Adding the ability to create repositories from a template. Most code borrowed from FrediKats PR 2187 but with fixed tests. Baptiste preview tag added to all repository endpoints mentioned in the GitHub Api documentation.
Further testing and IObservable code added to satisfy tests.