Skip to content

Add support for multi users and orgs in SearchCodeRequest#2291

Merged
shiftkey merged 3 commits intooctokit:mainfrom
kiriwalawren:orgs-users
Feb 13, 2021
Merged

Add support for multi users and orgs in SearchCodeRequest#2291
shiftkey merged 3 commits intooctokit:mainfrom
kiriwalawren:orgs-users

Conversation

@kiriwalawren
Copy link
Contributor

No description provided.

@shiftkey shiftkey changed the title Add support for multi users and orgs in SearchCodeRquest Add support for multi users and orgs in SearchCodeRequest Feb 13, 2021
@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #2291 (0da587d) into main (4ca8ea0) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
- Coverage   65.97%   65.96%   -0.01%     
==========================================
  Files         553      553              
  Lines       14435    14437       +2     
  Branches      844      846       +2     
==========================================
  Hits         9524     9524              
- Misses       4752     4754       +2     
  Partials      159      159              
Impacted Files Coverage Δ
Octokit/Models/Request/SearchCodeRequest.cs 87.71% <75.00%> (-3.19%) ⬇️

Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ecarlson94!

I think this is a reasonable change to include, just needs some release notes to indicate the change from string to string[] for Organizations and Users on SearchCodeRequest

@shiftkey shiftkey merged commit 2054943 into octokit:main Feb 13, 2021
@shiftkey
Copy link
Member

release_notes: Added support for specifying multiple users or organizations when searching for code

@shiftkey
Copy link
Member

shiftkey commented Feb 13, 2021

advisories: SearchCodeRequest.Users and SearchCodeRequest.Organizations now expects an array of strings, as the underling API supports searching for multiple users or organizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants