[Ready for review] Add DeleteBranchOnMerge option for repositories#2268
Merged
shiftkey merged 1 commit intooctokit:mainfrom Feb 13, 2021
Merged
[Ready for review] Add DeleteBranchOnMerge option for repositories#2268shiftkey merged 1 commit intooctokit:mainfrom
shiftkey merged 1 commit intooctokit:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2268 +/- ##
==========================================
- Coverage 65.97% 65.96% -0.02%
==========================================
Files 553 553
Lines 14435 14439 +4
Branches 844 844
==========================================
Hits 9524 9524
- Misses 4752 4756 +4
Partials 159 159
|
Contributor
Author
|
@shiftkey Hi, sorry to tag you directly, I think you're a maintainer of this repo looking at previous PR's / commits though. I've had this PR opened for a month and it's a tiny change, would you mind reviewing it, or pointing me in the right direction to get it merged? |
shiftkey
force-pushed
the
add-delete-branch-on-merge
branch
from
740fe53 to
b881881
Compare
shiftkey
approved these changes
Feb 13, 2021
Member
shiftkey
left a comment
shiftkey
left a comment
There was a problem hiding this comment.
Thanks for the contribution @samcackett!
Member
|
release_notes: Added |
nickfloyd
added
Type: Bug
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, hopefully this is a simple change, I just wanted to add the
DeleteBranchOnMergeoption when creating or updating repositories. This is supported by the Github v3 API.I couldn't find any open issues for it to link to (should I create one?).
I've added all the tests I think I need to, but I haven't run the integration tests (I assume you have some CI setup to run these but if not let me know and I'll go through the pain of setting them up).
This is my first time contributing so please tell me if I've done anything incorrectly. I did read the contributions guide but I didn't see the point in adding a checklist as this is such a simple change.