-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Approved] Add repository topics #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shiftkey
merged 56 commits into
octokit:main
from
SeanKilleen:1707_add-repository-topics
Feb 25, 2021
Merged
Changes from 5 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
220e9a3
ReSharper auto migration
SeanKilleen 1d0cb56
Add read-ony list of topics to repository class
SeanKilleen 3fa7807
Switch to IReadOnlyList<> for immutability
SeanKilleen 56295b3
Add mercy preview to clients returning Task<Repository>
SeanKilleen 21d3bbd
get all topics method
SeanKilleen 4b3e57f
ReplaceAllTopics method
SeanKilleen 697d3d6
Add fields to search request
SeanKilleen efd373e
Add parameter qualifiers
SeanKilleen 620cb26
Correct my misunderstanding of what Topics represents
SeanKilleen dd518d3
Add preview header to AcceptHeaders
SeanKilleen 091bff0
Add headers
SeanKilleen cb5a06c
overloads for repository ID
SeanKilleen 4a178ea
Update the interface
SeanKilleen af48670
Convert to use ApiOptions
SeanKilleen e68a5b8
add overloads
SeanKilleen ad9b819
Observable for GetAllTopics
SeanKilleen 52db2ab
observable implementations for ReplaceAllTopics
SeanKilleen fca13f4
Use IObservable<string>
SeanKilleen 0b88b7a
Ah, I see -- need to sync up the signatures.
SeanKilleen 1cd3116
Is this the only way to make the signatures match up?
SeanKilleen 456f431
Some integration tests
SeanKilleen ebbe318
Add RepositoryTopics from #1721
SeanKilleen 7d8d0d7
Use RepositoryTopics class
SeanKilleen 95f102a
More signature updates
SeanKilleen 67998dc
Add ReplaceAllTopics test real quick
SeanKilleen ca9e8e9
Empty list by default
SeanKilleen 7761dbd
integration test updates
SeanKilleen 9b126e5
Additional tests for using repo ID
SeanKilleen 1e7ac1d
Some unit tests & corresponding changes
SeanKilleen 1792546
unit tests for the GetAllTopics method
SeanKilleen fd7a2be
Unit tests, including a failing one I don't understand
SeanKilleen 0d6da2a
extract client & connection to fields
SeanKilleen 327ee27
oops, bad argumnt
SeanKilleen c9ed7a7
RepositoryTopics unit tests
SeanKilleen 19ea9fd
Mark integration tests as such
SeanKilleen 27d4d68
Integreation tests for search
SeanKilleen 6068b1b
Some failing tests to fix soon
SeanKilleen fe182e1
more unit tests
SeanKilleen b7c6901
Update Octokit.Reactive/Clients/IObservableRepositoriesClient.cs
SeanKilleen 5dba2fd
Update Octokit.Tests.Integration/Clients/SearchClientTests.cs
SeanKilleen e55273b
Update Octokit.Tests.Integration/Clients/SearchClientTests.cs
SeanKilleen 30b2215
Update Octokit/Clients/IRepositoriesClient.cs
SeanKilleen cd0f082
Update Octokit/Clients/IRepositoriesClient.cs
SeanKilleen cdbb96b
Update Octokit.Tests/Clients/SearchClientTests.cs
SeanKilleen 550f4e3
Update Octokit/Clients/RepositoriesClient.cs
SeanKilleen 3e10bc2
Update Octokit/Helpers/ApiUrls.cs
SeanKilleen a6c49ed
Update Octokit/Clients/RepositoriesClient.cs
SeanKilleen 04161cf
Merge branch 'main' into 1707_add-repository-topics
SeanKilleen 4b62ec0
Merge branch 'main' into 1707_add-repository-topics
shiftkey 257be14
Use helpers and CreateRepositoryContext
SeanKilleen 5fb88ad
Merge branch 'main' into 1707_add-repository-topics
SeanKilleen 8730206
cleanup: explicit private modifier
SeanKilleen 84d6144
cleanup: field names
SeanKilleen fa94465
cleanup: extract variable
SeanKilleen c5574ed
cleanup: spacing
SeanKilleen 2bc3df5
Cleanup: usings
SeanKilleen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.