Skip to content

preview support for repository visibility#2217

Merged
shiftkey merged 5 commits intooctokit:mainfrom
IvanJosipovic:main
Feb 21, 2021
Merged

preview support for repository visibility#2217
shiftkey merged 5 commits intooctokit:mainfrom
IvanJosipovic:main

Conversation

@IvanJosipovic
Copy link
Contributor

@IvanJosipovic IvanJosipovic commented Jun 23, 2020

Fixes #2149

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #2217 (d9c445a) into main (e40c792) will decrease coverage by 0.02%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main    #2217      +/-   ##
==========================================
- Coverage   65.93%   65.91%   -0.03%     
==========================================
  Files         553      553              
  Lines       14465    14465              
  Branches      846      846              
==========================================
- Hits         9538     9535       -3     
- Misses       4769     4771       +2     
- Partials      158      159       +1     
Impacted Files Coverage Δ
Octokit/Helpers/AcceptHeaders.cs 100.00% <ø> (ø)
Octokit/Models/Request/NewRepository.cs 29.41% <0.00%> (ø)
Octokit/Models/Request/RepositoryUpdate.cs 61.11% <0.00%> (ø)
Octokit/Models/Response/Repository.cs 5.55% <0.00%> (ø)
Octokit/Clients/RepositoriesClient.cs 95.05% <100.00%> (ø)
Octokit/Models/Request/RepositoryRequest.cs 29.41% <100.00%> (ø)
Octokit.Reactive/Helpers/ObservableExtensions.cs 90.29% <0.00%> (-2.92%) ⬇️
... and 1 more

@cliffchapmanrbx
Copy link

It's been a few months, any update on this?

Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @IvanJosipovic! I'm going to pull this in to the next update.

/// The visibility.
/// </value>
public RepositoryVisibility? Visibility { get; set; }
public RepositoryRequestVisibility? Visibility { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting this for the release notes: breaking change RepositoryVisibility -> RepositoryRequestVisibility

@shiftkey shiftkey merged commit 6105a9d into octokit:main Feb 21, 2021
@shiftkey
Copy link
Member

release_notes: Add support for repository visibility preview

@shiftkey
Copy link
Member

advisories: due to supporting repository previews, the type on RepositoryRequest.Visibility has been renamed from RepositoryVisibility to RepositoryRequestVisibility to avoid clashing with the response type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

preview support for repository visibility

4 participants