keyToggle and keyTap not working on MacOS when the current language is non-Latin#294
Merged
Merged
Conversation
Contributor
Author
|
Hey, Any news on this PR? |
Owner
|
I'll take a look this weekend, thanks for the PR! |
Owner
|
Sorry everyone, releasing and building is currently difficult since I have to spin up a bunch of VMs. I'm going to work on getting TravisCI publishing so it's easier to test and deploy. Thanks for the PR! |
|
@octalmage It works properly if it is set to "US" input source, but is this PR compatible with Japanese input source?
|
huanvb
pushed a commit
to huanvb/robotjs
that referenced
this pull request
Jan 13, 2022
huanvb
added a commit
to huanvb/robotjs
that referenced
this pull request
Jan 13, 2022
Related octalmage#294 Co-authored-by: Vu Ba Huan <vbhuan@cmc.com.vn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keyToggle and keyTap are working only with ASCII chars.
The dictionary with chars and the key codes is generated using the current language and if this chars are not ASCII we won't be able to find the corresponding key code that we need for executing keyToggle. This will result in not printing any chars.
With this patch, no matter of the current language the dictionary will be constructed only from ASCII chars. This fixes the issue.