Add typescript declaration file#225
Merged
Merged
Conversation
Owner
|
Awesome! One note, keyTap and keyToggle both also support an array of modifiers. Should this be represented? |
Contributor
Author
|
Yes, absolutely. This should fix that. Doing great work with the project btw 😄 |
octalmage
approved these changes
Sep 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #224.
I'm not a pro typescripter myself, but this is the custom declaration file I use in my projects.
One thing though: I used
anyas theimagetype of aBitmap, instead ofBuffer, as you'd have to pull in the node type definitions to have access toBufferwhich seems a bit overkill.