Skip to content

fix(dlm): don't compare the table structure if syncTableStructure is off#3014

Merged
yhilmare merged 1 commit into
dev/4.3.xfrom
tianke_431_fix_sync_table_structure
Jul 25, 2024
Merged

fix(dlm): don't compare the table structure if syncTableStructure is off#3014
yhilmare merged 1 commit into
dev/4.3.xfrom
tianke_431_fix_sync_table_structure

Conversation

@guowl3
Copy link
Copy Markdown
Collaborator

@guowl3 guowl3 commented Jul 25, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

  1. Don't compare the table structure if syncTableStructure is off.
  2. Sync table structure only supports MySQL and OMySQL. It throws an unsupported exception if other databases are chosen.

Which issue(s) this PR fixes:

Fixes #2844 #2845

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@guowl3 guowl3 added this to the ODC 4.3.1 milestone Jul 25, 2024
@guowl3 guowl3 self-assigned this Jul 25, 2024
@guowl3 guowl3 requested review from yhilmare and yizhouxw as code owners July 25, 2024 07:15
Copy link
Copy Markdown
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 743c034 into dev/4.3.x Jul 25, 2024
@yhilmare yhilmare deleted the tianke_431_fix_sync_table_structure branch July 25, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants