Skip to content

enhancement(notification): support configuring network timeout for http sender#2782

Merged
yhilmare merged 1 commit into
dev/4.3.0from
wenmu_430_fix_notification_support_timeout_config
Jun 19, 2024
Merged

enhancement(notification): support configuring network timeout for http sender#2782
yhilmare merged 1 commit into
dev/4.3.0from
wenmu_430_fix_notification_support_timeout_config

Conversation

@LuckyPickleZZ
Copy link
Copy Markdown
Member

What type of PR is this?

type-enhancement

What this PR does / why we need it:

Some users want us to support configuring the timeout for sending notifications. Therefore, a configuration has been added to the system config table.

Which issue(s) this PR fixes:

Fixes #2582

Copy link
Copy Markdown
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit b6e6511 into dev/4.3.0 Jun 19, 2024
@yhilmare yhilmare deleted the wenmu_430_fix_notification_support_timeout_config branch June 19, 2024 10:41
@LuckyPickleZZ LuckyPickleZZ restored the wenmu_430_fix_notification_support_timeout_config branch July 24, 2024 09:01
@LuckyPickleZZ LuckyPickleZZ deleted the wenmu_430_fix_notification_support_timeout_config branch July 24, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants