Skip to content

fix(table-object): there would be an NPE if fail to parse index ddl#2776

Merged
yhilmare merged 1 commit into
dev/4.3.0from
wenmu_430_fix_view_table_NPE
Jun 20, 2024
Merged

fix(table-object): there would be an NPE if fail to parse index ddl#2776
yhilmare merged 1 commit into
dev/4.3.0from
wenmu_430_fix_view_table_NPE

Conversation

@LuckyPickleZZ
Copy link
Copy Markdown
Member

What type of PR is this?

type-bug

What this PR does / why we need it:

If fail to parse index ddl, there is an coding problem causing NPE. It should be avoided.
And the exception of viewing table now is eaten. It's difficult to find the problem's root cause.

Which issue(s) this PR fixes:

Fixes #2747

@LuckyPickleZZ LuckyPickleZZ added the type-bug Something isn't working label Jun 19, 2024
@LuckyPickleZZ LuckyPickleZZ added this to the ODC 4.3.0-bp1 milestone Jun 19, 2024
@LuckyPickleZZ LuckyPickleZZ self-assigned this Jun 19, 2024
Copy link
Copy Markdown
Contributor

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare
Copy link
Copy Markdown
Contributor

what's the root cause of this?

Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 74b6fd5 into dev/4.3.0 Jun 20, 2024
@yhilmare yhilmare deleted the wenmu_430_fix_view_table_NPE branch June 20, 2024 02:22
@LuckyPickleZZ LuckyPickleZZ restored the wenmu_430_fix_view_table_NPE branch July 24, 2024 09:01
@LuckyPickleZZ LuckyPickleZZ deleted the wenmu_430_fix_view_table_NPE branch July 24, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants