Skip to content

fix(structure-comparison): syntax error when executing structure comparison #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yhilmare merged 6 commits into from
Jun 5, 2024
Merged

fix(structure-comparison): syntax error when executing structure comparison #2638

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ebb958
syntax error when generating parti
yhilmare Jun 4, 2024
d97f6ba
fix unit test error
yhilmare Jun 4, 2024
a56bcb0
add defs for hash and key parti
yhilmare Jun 5, 2024
8fb551b
Merge branch 'dev/4.3.0' of https://github.com/oceanbase/odc into fix…
yhilmare Jun 5, 2024
91b0da0
adapt for hash parti
yhilmare Jun 5, 2024
65189fc
update submodule
yhilmare Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...db-browser/src/main/java/com/oceanbase/tools/dbbrowser/editor/DBTablePartitionEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,13 @@ public String generateCreateDefinitionDDL(@NotNull DBTablePartition partition) {
if (Objects.nonNull(partition.getSubpartitionTemplated()) && partition.getSubpartitionTemplated()) {
generateCreateTemplateSubPartition(partition, sqlBuilder);
}
if (Objects.nonNull(partition.getPartitionOption().getPartitionsNum())) {
sqlBuilder.append("\nPARTITIONS ")
.append(String.valueOf(partition.getPartitionOption().getPartitionsNum()));
if (partition.getPartitionOption().getType() == DBTablePartitionType.HASH
|| partition.getPartitionOption().getType() == DBTablePartitionType.KEY) {
return sqlBuilder.toString();
if (partition.getPartitionOption().getType() == DBTablePartitionType.HASH
|| partition.getPartitionOption().getType() == DBTablePartitionType.KEY) {
if (Objects.nonNull(partition.getPartitionOption().getPartitionsNum())) {
sqlBuilder.append("\nPARTITIONS ")
.append(String.valueOf(partition.getPartitionOption().getPartitionsNum()));
}
return sqlBuilder.toString();
Comment thread
yhilmare marked this conversation as resolved.
Outdated
}
appendDefinitions(partition, sqlBuilder);
return sqlBuilder.toString();
Expand Down