Skip to content

fix(schema): function and procedure list is not ordered by their name in ob-mysql #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yhilmare merged 1 commit into from
Jun 4, 2024
Merged

fix(schema): function and procedure list is not ordered by their name in ob-mysql #2636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...browser/src/main/java/com/oceanbase/tools/dbbrowser/schema/doris/DorisSchemaAccessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ public List<DBPLObjectIdentity> listFunctions(String schemaName) {
sb.append(
"select ROUTINE_NAME as name, ROUTINE_SCHEMA as schema_name, ROUTINE_TYPE as type from `information_schema`.`routines` where ROUTINE_SCHEMA=");
sb.value(schemaName);
sb.append(" and ROUTINE_TYPE = 'FUNCTION';");
sb.append(" and ROUTINE_TYPE = 'FUNCTION' order by name asc;");

return jdbcOperations.query(sb.toString(), new BeanPropertyRowMapper<>(DBPLObjectIdentity.class));
}
Expand All @@ -379,7 +379,7 @@ public List<DBPLObjectIdentity> listProcedures(String schemaName) {
sb.append(
"select ROUTINE_NAME as name, ROUTINE_SCHEMA as schema_name, ROUTINE_TYPE as type from `information_schema`.`routines` where ROUTINE_SCHEMA=");
sb.value(schemaName);
sb.append(" and ROUTINE_TYPE = 'PROCEDURE';");
sb.append(" and ROUTINE_TYPE = 'PROCEDURE' order by name asc;");

return jdbcOperations.query(sb.toString(), new BeanPropertyRowMapper<>(DBPLObjectIdentity.class));
}
Expand Down
4 changes: 2 additions & 2 deletions ...in/java/com/oceanbase/tools/dbbrowser/schema/mysql/MySQLNoLessThan5700SchemaAccessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ public List<DBPLObjectIdentity> listFunctions(String schemaName) {
sb.append(
"select ROUTINE_NAME as name, ROUTINE_SCHEMA as schema_name, ROUTINE_TYPE as type from `information_schema`.`routines` where ROUTINE_SCHEMA=");
sb.value(schemaName);
sb.append(" and ROUTINE_TYPE = 'FUNCTION';");
sb.append(" and ROUTINE_TYPE = 'FUNCTION' order by name asc;");

return jdbcOperations.query(sb.toString(), new BeanPropertyRowMapper<>(DBPLObjectIdentity.class));
}
Expand All @@ -375,7 +375,7 @@ public List<DBPLObjectIdentity> listProcedures(String schemaName) {
sb.append(
"select ROUTINE_NAME as name, ROUTINE_SCHEMA as schema_name, ROUTINE_TYPE as type from `information_schema`.`routines` where ROUTINE_SCHEMA=");
sb.value(schemaName);
sb.append(" and ROUTINE_TYPE = 'PROCEDURE';");
sb.append(" and ROUTINE_TYPE = 'PROCEDURE' order by name asc;");

return jdbcOperations.query(sb.toString(), new BeanPropertyRowMapper<>(DBPLObjectIdentity.class));
}
Expand Down