Skip to content

fix(session): failed to set nls parameters for native oracle in sql-console#2501

Merged
yhilmare merged 1 commit into
dev/4.3.0from
fix/failed_to_set_nls_for_native_oracle
May 27, 2024
Merged

fix(session): failed to set nls parameters for native oracle in sql-console#2501
yhilmare merged 1 commit into
dev/4.3.0from
fix/failed_to_set_nls_for_native_oracle

Conversation

@yhilmare
Copy link
Copy Markdown
Contributor

What type of PR is this?

type-bug

What this PR does / why we need it:

failed to set nls parameter for native oracle in sql-console

Which issue(s) this PR fixes:

Fixes #2421

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added the type-bug Something isn't working label May 27, 2024
@yhilmare yhilmare added this to the ODC 4.3.0 milestone May 27, 2024
@yhilmare yhilmare self-assigned this May 27, 2024
@yhilmare yhilmare requested a review from LuckyPickleZZ as a code owner May 27, 2024 02:50
Copy link
Copy Markdown
Member

@LuckyPickleZZ LuckyPickleZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 1163f55 into dev/4.3.0 May 27, 2024
@yhilmare yhilmare deleted the fix/failed_to_set_nls_for_native_oracle branch May 27, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants