fix(taskframework): daemon job be fired at one time in cluster model#2408
Merged
Conversation
krihy
changed the title
yizhouxw
approved these changes
May 17, 2024
Contributor
yizhouxw
left a comment
yizhouxw
left a comment
There was a problem hiding this comment.
lgtm,
may improve performance later, currently multiple nodes may fetch same tasks, aquire conflict lock, which may cause unneccessary lock wait
yizhouxw
pushed a commit
that referenced
this pull request
Jun 22, 2024
…2408) * rm datasource * add properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
daemon job running be fired at one time in cluster model, so we remove datasource and quartz will use RAMJobStore as non-cluster model
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: