security: test masking using rounding algorithm may cause denial of service (DoS) risk#2271
Merged
yhilmare merged 1 commit intoApr 22, 2024
Conversation
smallsheeeep
changed the title
Contributor
|
title may start with |
smallsheeeep
changed the title
Contributor
Author
okay, done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
When I test masking using rounding algorithm, and input a big decimal such as 100e999999, then it occupied large CPU usage. And if I mock many these request at same time ,then DoS may occur.
This PR fix it by adding a
OdcBigDecimalCheckerto check if the BigDecimal value passed in has a denial of service risk.Which issue(s) this PR fixes:
Fixes #2270
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: