fix(datasource): connecting failed in OceanBase Oracle after correcting the username#1797
Merged
Merged
Conversation
MarkPotato777
changed the title
MarkPotato777
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
ConnectionConfig.defaultSchemais deprecated at the API level, so this PR adds@JsonIgnoreon this field to prevent the issue which is that when users update the data source username, the front-end will pass thedefaultSchemawhich is obtained from thedetailAPI, and this will cause some logic error in the back-end: the odc server will not update the default schema using the username, it will use the old default schema passed by the front-end.Which issue(s) this PR fixes:
Fixes #1626
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: