Skip to content

fix(db-browser): failed to getTable in mysql5.6#1635

Merged
yhilmare merged 3 commits into
dev/4.2.xfrom
fix/jingtian_424_failed_to_get_table_in_mysql5.6
Mar 4, 2024
Merged

fix(db-browser): failed to getTable in mysql5.6#1635
yhilmare merged 3 commits into
dev/4.2.xfrom
fix/jingtian_424_failed_to_get_table_in_mysql5.6

Conversation

@PeachThinking
Copy link
Copy Markdown
Contributor

What type of PR is this?

type-bug
module-database oboject

What this PR does / why we need it:

There is no GENERATION_EXPRESSION field in the information_schema.columns table of mysql 5.6 because this version does not support Generated Column.

  • Create a new MySQLNoLessThan5600SchemaAccessor class to adapt it.
  • rename MySQLNoGreaterThan5740SchemaAccessor to MySQLNoLessThan5700SchemaAccessor
  • rename MySQLNoGreaterThan5740StatsAccessor to MySQLNoLessThan5700StatsAccessor
  • rename MySQLNoGreaterThan5740IndexEditor to MySQLNoLessThan5700IndexEditor

Which issue(s) this PR fixes:

Fixes #1335

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@PeachThinking PeachThinking added the type-bug Something isn't working label Feb 27, 2024
@PeachThinking PeachThinking added this to the ODC 4.2.4 milestone Feb 27, 2024
@PeachThinking PeachThinking self-assigned this Feb 27, 2024
@PeachThinking PeachThinking force-pushed the fix/jingtian_424_failed_to_get_table_in_mysql5.6 branch from 67f2cf7 to f147bea Compare February 27, 2024 03:05
yizhouxw
yizhouxw previously approved these changes Mar 1, 2024
Copy link
Copy Markdown
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 53ac2b0 into dev/4.2.x Mar 4, 2024
@yhilmare yhilmare deleted the fix/jingtian_424_failed_to_get_table_in_mysql5.6 branch March 4, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants