fix(integration): garbled code exists when using Chinese in request body#1625
Merged
yhilmare merged 1 commit intoFeb 26, 2024
Merged
Conversation
smallsheeeep
added
type-bug
smallsheeeep
requested review from
MarkPotato777,
krihy,
yhilmare and
yizhouxw
yhilmare
deleted the
bugfix/gaoda_42x_integration_request_body_garbled_code
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
type-external integration
What this PR does / why we need it:
There is a bug: Garbled code exists when using Chinese in request body of external integration configuration.
Root cause: When the content-type is RAW, then we build HTTP request entity through
EntityBuilder.create().setText(encryptedBody).build(). Then the default charset isISO_8859_1rather thanUTF_8causing garbled code for Chinese.This PR fix it by using
StringEntity(bodyString, StandardCharsets.UTF_8).Which issue(s) this PR fixes:
Fixes #1624
Special notes for your reviewer:
Self-test Passed.
Additional documentation e.g., usage docs, etc.: