Skip to content

fix(db-browser): failed to list tables when ob's version is no greater than 2.2.30#1478

Merged
yhilmare merged 1 commit into
dev/4.2.xfrom
fix/jingtian_423bp_fix_obmysql2230_listTables
Jan 30, 2024
Merged

fix(db-browser): failed to list tables when ob's version is no greater than 2.2.30#1478
yhilmare merged 1 commit into
dev/4.2.xfrom
fix/jingtian_423bp_fix_obmysql2230_listTables

Conversation

@PeachThinking
Copy link
Copy Markdown
Contributor

@PeachThinking PeachThinking commented Jan 30, 2024

What type of PR is this?

type-bug
module-db-browser

What this PR does / why we need it:

  1. ob oracle 2230 do not have SYS.ALL_VIRTUAL_DATABASE_REAL_AGENT internal table, In ob oracle mode, ALL_TABLES view information is uniformly queried to listTables.

  2. fix get the DBSchemaAccessor for different versions

Which issue(s) this PR fixes:

Fixes #1476

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@PeachThinking PeachThinking self-assigned this Jan 30, 2024
@PeachThinking PeachThinking added the type-bug Something isn't working label Jan 30, 2024
@PeachThinking PeachThinking added this to the ODC 4.2.3-bp milestone Jan 30, 2024
@PeachThinking PeachThinking changed the title fix(db-browser): oboracle less than or equals to 2230 listTables throws error [WIP]fix(db-browser): oboracle less than or equals to 2230 listTables throws error Jan 30, 2024
@PeachThinking PeachThinking force-pushed the fix/jingtian_423bp_fix_obmysql2230_listTables branch from 7914894 to 175ce92 Compare January 30, 2024 08:19
@PeachThinking PeachThinking removed the request for review from LuckyPickleZZ January 30, 2024 08:22
@PeachThinking PeachThinking changed the title [WIP]fix(db-browser): oboracle less than or equals to 2230 listTables throws error fix(db-browser): oboracle less than or equals to 2230 listTables throws error Jan 30, 2024
@yhilmare yhilmare modified the milestones: ODC 4.2.3-bp, ODC 4.2.4 Jan 30, 2024
@yhilmare
Copy link
Copy Markdown
Contributor

yhilmare commented Jan 30, 2024

pr title naming suggestion: failed to list tables when ob's version is no greater than 2.2.30

@PeachThinking PeachThinking changed the title fix(db-browser): oboracle less than or equals to 2230 listTables throws error fix(db-browser): failed to list tables when ob's version is no greater than 2.2.30 Jan 30, 2024
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 91c496b into dev/4.2.x Jan 30, 2024
@yhilmare yhilmare deleted the fix/jingtian_423bp_fix_obmysql2230_listTables branch January 30, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority-high type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants