Skip to content

fix(sql-execution): can not set a delimiter longer than 2#1414

Merged
yhilmare merged 2 commits into
dev/4.2.3from
fix/shanlu_delimiter_error
Jan 17, 2024
Merged

fix(sql-execution): can not set a delimiter longer than 2#1414
yhilmare merged 2 commits into
dev/4.2.3from
fix/shanlu_delimiter_error

Conversation

@yhilmare
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare commented Jan 17, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

we can not set a delimiter longer than 2:

delimiter $$$
select 1
from dual $$$

which cause an out of bound exception, this issue may cause by this pr #976

Which issue(s) this PR fixes:

Fixes #1412

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

@yhilmare yhilmare added the type-bug Something isn't working label Jan 17, 2024
@yhilmare yhilmare added this to the ODC 4.2.3-bp milestone Jan 17, 2024
@yhilmare yhilmare self-assigned this Jan 17, 2024
@yhilmare yhilmare linked an issue Jan 17, 2024 that may be closed by this pull request
[Bug]: SQL checks containing delimiters will report an error #1412
Closed
@yhilmare yhilmare changed the title fix(sql-execution): can not set delimiter longer than 2 fix(sql-execution): can not set a delimiter longer than 2 Jan 17, 2024
MarkPotato777
MarkPotato777 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit 20a5b75 into dev/4.2.3 Jan 17, 2024
@yhilmare yhilmare deleted the fix/shanlu_delimiter_error branch January 17, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yizhouxw yizhouxw Awaiting requested review from yizhouxw

@smallsheeeep smallsheeeep Awaiting requested review from smallsheeeep

1 more reviewer

@MarkPotato777 MarkPotato777 MarkPotato777 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yhilmare yhilmare

Labels

type-bug Something isn't working

Projects

ODC
Archived in project

Milestone

ODC 4.2.3-bp

Development

Successfully merging this pull request may close these issues.

[Bug]: SQL checks containing delimiters will report an error

2 participants

@yhilmare @MarkPotato777