Skip to content

fix(db-browser): fix the visualization of mysql table structure design and supports strings enclosed in single quotes#1401

Merged
yhilmare merged 2 commits into
oceanbase:dev/4.2.xfrom
ISADBA:baseline/20240115/v1pr
Jan 16, 2024
Merged

fix(db-browser): fix the visualization of mysql table structure design and supports strings enclosed in single quotes#1401
yhilmare merged 2 commits into
oceanbase:dev/4.2.xfrom
ISADBA:baseline/20240115/v1pr

Conversation

@ISADBA
Copy link
Copy Markdown
Collaborator

@ISADBA ISADBA commented Jan 16, 2024

What type of PR is this?

type-bug
dbbrowser

What this PR does / why we need it:

fix the visualization of MySQL table structure design, supporting strings enclosed in single quotes ('').

Which issue(s) this PR fixes:

Fixes #1317

Special notes for your reviewer:

have not frontend change need。

Additional documentation e.g., usage docs, etc.:

none

yhilmare and others added 2 commits December 26, 2023 13:50
merge dev/4.2.x into main
…esign, supporting strings enclosed in single quotes ('').
@yhilmare yhilmare added the type-bug Something isn't working label Jan 16, 2024
@yhilmare yhilmare added this to the ODC 4.2.4 milestone Jan 16, 2024
@yhilmare yhilmare changed the base branch from main to dev/4.2.x January 16, 2024 07:54
@yhilmare yhilmare changed the title fix(dbbrowser):fix the visualization of MySQL table structure design, supporting strings enclosed in single quotes (''). fix(db-browser): fix the visualization of mysql table structure design and supports strings enclosed in single quotes Jan 16, 2024
@yhilmare
Copy link
Copy Markdown
Contributor

lgtm

Copy link
Copy Markdown
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice solution! we can handle more default value scenarios for mysql mode now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

3 participants