fix(osc): osc task don't show manual swap table name when full migrate is completed#1357
Merged
Merged
Conversation
krihy
added
type-bug
krihy
added a commit
that referenced
this pull request
Jan 12, 2024
…e is completed (#1357) * fix manual swap table * record manualSwapTableTasksChanged * fix swap table list * format code
krihy
added a commit
that referenced
this pull request
Jan 12, 2024
…e is completed (#1357) * fix manual swap table * record manualSwapTableTasksChanged * fix swap table list * format code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
module-online schema change
What this PR does / why we need it:
fix osc percentage continue execute when
isManualSwapTableEnabledis true, we should update it to task result json, the swap table button show or not based onisManualSwapTableEnabledWhich issue(s) this PR fixes:
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: