Skip to content

fix(sql-check): failed to check statement when connect to a lower case schema #1341

Merged
yhilmare merged 2 commits into
dev/4.2.xfrom
feat/shanlu_partition_plan
Jan 3, 2024
Merged

fix(sql-check): failed to check statement when connect to a lower case schema #1341
yhilmare merged 2 commits into
dev/4.2.xfrom
feat/shanlu_partition_plan

Conversation

@yhilmare
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare commented Jan 3, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1337

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

@yhilmare yhilmare added the type-bug Something isn't working label Jan 3, 2024
@yhilmare yhilmare added this to the ODC 4.2.3-bp milestone Jan 3, 2024
@yhilmare yhilmare self-assigned this Jan 3, 2024
@yhilmare yhilmare linked an issue Jan 3, 2024 that may be closed by this pull request
[Bug]: Oracle mode lowercase database fails to perform database change pre-check #1337
Closed
MarkPotato777
MarkPotato777 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit a801cb7 into dev/4.2.x Jan 3, 2024
yhilmare added a commit that referenced this pull request Jan 15, 2024
@yhilmare
fix(sql-check): failed to check statement when connect to a lower cas…
9dc1b3d 
…e schema (#1341)

* fix issue #1337

* update submodule
LuckyPickleZZ pushed a commit that referenced this pull request Jan 15, 2024
@yhilmare
fix(sql-check): failed to check statement when connect to a lower cas…
b754b9d 
…e schema (#1341)

* fix issue #1337

* update submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yizhouxw yizhouxw Awaiting requested review from yizhouxw yizhouxw is a code owner

1 more reviewer

@MarkPotato777 MarkPotato777 MarkPotato777 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yhilmare yhilmare

Labels

type-bug Something isn't working

Projects

ODC
Archived in project

Milestone

ODC 4.2.3-bp

Development

Successfully merging this pull request may close these issues.

[Bug]: Oracle mode lowercase database fails to perform database change pre-check

2 participants

@yhilmare @MarkPotato777