Parenthesize #992
Merged
Parenthesize #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trefis
reviewed
Jul 4, 2019
| fprintf ppf "( %s )" name | ||
| if name <> "" && (name.[0] = '*' || name.[String.length name - 1] = '*') | ||
| then fprintf ppf "( %s )" name | ||
| else fprintf ppf "(%s)" name |
Contributor
There was a problem hiding this comment.
Why do that extra work here (and in 4.02) but not in any of the following versions?
Contributor
Author
There was a problem hiding this comment.
Following versions handle that differently, but have the right behavior (otherwise the tests would fail).
trefis
approved these changes
Jul 9, 2019
let-def
pushed a commit
to let-def/opam-repository
that referenced
this pull request
Jul 9, 2019
CHANGES:
Tue Jul 9 17:34:42 CEST 2019
+ backend
- `**` globbing in .merlin won't look into hidden directories
(starting with a '.') (by Daniel Bünzl, ocaml/merlin#990)
- fallback to "/dev/null" configuration for findlib
- better 4.08 support:
+ support for letop (let+, and+, ...) (ocaml/merlin#986)
+ fix parsing recovery for 4.08 constructions (ocaml/merlin#987)
+ catch an exception raised by 4.08 Printtyp trying to rename a
persistent identifier (ocaml/merlin#991)
- locate: treat local locations differently from external locations (coming
from a cmi), this fixes "jump to definition" on mutually recursive
bindings (ocaml/merlin#984)
- when completing an infix operator in a sub-module, wrap with () (ocaml/merlin#992)
+ editor modes
- emacs
+ fix position computation in presence of tabs or multi-byte characters (ocaml/merlin#981)
+ log arguments in "merlin-debug-last-commands" (ocaml/merlin#981)
- vim
+ install reason.vim file (by Hezekiah M. Carty, ocaml/merlin#974)
let-def
pushed a commit
to let-def/opam-repository
that referenced
this pull request
Jul 15, 2019
CHANGES:
Mon Jul 15 11:10:35 CEST 2019
+ backend
- `**` globbing in .merlin won't look into hidden directories
(starting with a '.') (by Daniel Bünzl, ocaml/merlin#990)
- fallback to "/dev/null" configuration for findlib
- better 4.08 support:
+ support for letop (let+, and+, ...) (ocaml/merlin#986)
+ fix parsing recovery for 4.08 constructions (ocaml/merlin#987)
+ catch an exception raised by 4.08 Printtyp trying to rename a
persistent identifier (ocaml/merlin#991)
- locate: treat local locations differently from external locations (coming
from a cmi), this fixes "jump to definition" on mutually recursive
bindings (ocaml/merlin#984)
- when completing an infix operator in a sub-module, wrap with () (ocaml/merlin#992)
- disable arity checks on externals (for Bucklescript compatibility)
- remove parser preprocessing (simplify compilation for OCaml < 4.08) (ocaml/merlin#997)
+ editor modes
- emacs
+ fix position computation in presence of tabs or multi-byte characters (ocaml/merlin#981)
+ log arguments in "merlin-debug-last-commands" (ocaml/merlin#981)
- vim
+ install reason.vim file (by Hezekiah M. Carty, ocaml/merlin#974)
let-def
pushed a commit
to let-def/opam-repository
that referenced
this pull request
Jul 15, 2019
CHANGES:
Mon Jul 15 11:10:35 CEST 2019
+ backend
- `**` globbing in .merlin won't look into hidden directories
(starting with a '.') (by Daniel Bünzl, ocaml/merlin#990)
- fallback to "/dev/null" configuration for findlib
- better 4.08 support:
+ support for letop (let+, and+, ...) (ocaml/merlin#986)
+ fix parsing recovery for 4.08 constructions (ocaml/merlin#987)
+ catch an exception raised by 4.08 Printtyp trying to rename a
persistent identifier (ocaml/merlin#991)
- locate: treat local locations differently from external locations (coming
from a cmi), this fixes "jump to definition" on mutually recursive
bindings (ocaml/merlin#984)
- when completing an infix operator in a sub-module, wrap with () (ocaml/merlin#992)
- disable arity checks on externals (for Bucklescript compatibility)
- remove parser preprocessing (simplify compilation for OCaml < 4.08) (ocaml/merlin#997)
+ editor modes
- emacs
+ fix position computation in presence of tabs or multi-byte characters (ocaml/merlin#981)
+ log arguments in "merlin-debug-last-commands" (ocaml/merlin#981)
- vim
+ install reason.vim file (by Hezekiah M. Carty, ocaml/merlin#974)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifiers that are infix operators (
+,::, ...mod) are no longer parenthesized during completion.This PR improves that.