Skip to content

Always pass -short-paths when calling ocamlc -i #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from Jan 7, 2019
Merged

Always pass -short-paths when calling ocamlc -i #1743

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6328c1
Always pass -short-paths when calling `ocamlc -i`
jeremiedimino Jan 7, 2019
0edae36
Merge branch 'master' into fix-1504
jeremiedimino Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ unreleased
- Let `Configurator` handle `sizeof` (in addition to negative numbers).
(#1726, fixes #1723, @Chris00)

- Fix an issue causing menhir generated parsers to fail to build in
some cases. The fix is to systematically use `-short-paths` when
calling `ocamlc -i` (#1743, fix #1504, @diml)

1.6.2 (05/12/2018)
------------------

Expand Down
1 change: 1 addition & 0 deletions src/module_compilation.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ let ocamlc_i ?sandbox ?(flags=[]) ~dep_graphs cctx (m : Module.t) ~output =
| Some (m : Module.t) ->
As ["-open"; Module.Name.to_string (Module.name m)])
; As flags
; A "-short-paths"
; A "-i"; Ml_kind.flag Impl; Dep src
]
>>^ (fun act -> Action.with_stdout_to output act)
Expand Down