Specifies the object directory in module #1709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobot
force-pushed
the
add_obj_dir_in_modules
branch
2 times, most recently
from
9aeb141 to
dce473d
Compare
rgrinberg
requested changes
Dec 22, 2018
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
Looks really good. I'm really looking forward to this change to attempt to get rid of all the copying for virtual module implementations. But to do that, I think I will need a Obj_dir.t per impl/intf. Do you have any comments or suggestions on how I should do that?
bobot
force-pushed
the
add_obj_dir_in_modules
branch
from
a85e9e0 to
d594a49
Compare
Collaborator
Author
I think we should have an easier way to compute the |
rgrinberg
approved these changes
Dec 23, 2018
- Adds Module.Source.t for module yet without object - Remove the need to thread the obj_dir everywhere - Requires to convert the virtual modules to the implementation module Signed-off-by: François Bobot <[email protected]>
bobot
force-pushed
the
add_obj_dir_in_modules
branch
from
d594a49 to
cd213cd
Compare
Member
|
Merged as I need this for other work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big refactorisation that push the object directory inside Module.t
obj_dirobj_direverywhere