Skip to content

Do not reset flags for compatibility modules #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgrinberg merged 2 commits into from
Oct 2, 2018
Merged

Do not reset flags for compatibility modules #1382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43694a4
Do not reset flags for compatibility modules
rgrinberg Oct 2, 2018
1782335
Update CHANGES
rgrinberg Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ next

- Support for new menhir rules (#863, fix #305, @fpottier, @rgrinberg)

- Do not remove flags when compiling compatibility modules for wrapped mode
(#1382, fix #1364, @rgrinberg)

1.3.0 (23/09/2018)
------------------

Expand Down
3 changes: 1 addition & 2 deletions src/compilation_context.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ let for_alias_module t =

let for_wrapped_compat t modules =
{ t with
flags = Ocaml_flags.default ~profile:(SC.profile t.super_context)
; includes = Includes.empty
includes = Includes.empty
; alias_module = None
; stdlib = None
; modules
Expand Down