Set compiler's error-style and color through env vars in standalone mode #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
force-pushed
the
set-error-style-standalone
branch
from
e70e1e7 to
ed0e70e
Compare
Collaborator
Author
|
I realized as I was writing the PR text that this won't work as is since the compiler lib from older compilers don't expose those flags. |
Collaborator
Author
|
From a quick look it seems like updating |
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
set-error-style-standalone
branch
from
ed0e70e to
9dff466
Compare
|
Agreed |
Collaborator
Author
|
Cool, let's merge! Should we cut a |
|
Seems good to me! Are you happy to take care of it? :) |
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Jul 18, 2019
CHANGES: ### Fixed - Report errors according to the value of `OCAML_ERROR_STYLE` and `OCAML_COLOR` in the standalone driver (ocaml-ppx/ppxlib#83, @NathanReb)
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Jul 19, 2019
CHANGES: - Report errors according to the value of `OCAML_ERROR_STYLE` and `OCAML_COLOR` in the standalone driver (ocaml-ppx/ppxlib#83, @NathanReb)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Nov 21, 2019
CHANGES: - Do not produce a suprious empty correction when deriving_inline expands into an extension that undergoes further expansion (ocaml-ppx/ppxlib#86, @aalekseyev) - Add `Ppxlib.Quoter`. This module allows to generate hygienic code fragments in the spirit of ppx_deriving. (ocaml-ppx/ppxlib#92, @rgrinberg) - Allow for registering derivers on module type declarations. (ocaml-ppx/ppxlib#94, fix ocaml-ppx/ppxlib#83, @rgrinberg) - Fix parsing long idenitifiers. (ocaml-ppx/ppxlib#98, @NathanReb)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Nov 28, 2019
CHANGES: - Do not produce a suprious empty correction when deriving_inline expands into an extension that undergoes further expansion (ocaml-ppx/ppxlib#86, @aalekseyev) - Add `Ppxlib.Quoter`. This module allows to generate hygienic code fragments in the spirit of ppx_deriving. (ocaml-ppx/ppxlib#92, @rgrinberg) - Allow for registering derivers on module type declarations. (ocaml-ppx/ppxlib#94, fix ocaml-ppx/ppxlib#83, @rgrinberg) - Fix parsing long idenitifiers. (ocaml-ppx/ppxlib#98, @NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCaml 4.08 introduced to new flags allowing users to configure the error reporting style and use of colors.
Those can also be set via the env variables
OCAML_COLORandOCAML_ERROR_STYLE.When using a standalone
ppxlibdriver, the appropriate flags weren't set according to those env variables and therefore the error reporting wasn't impacted.A nice follow up could be to re-expose the command line flags from the standalone driver as well.