add test for EasyConfig comparison & hashing + add __ne__ definition #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(required for != comparisons to be correct)
ocaisa
pushed a commit
that referenced
this pull request
Oct 30, 2015
add test for EasyConfig comparison & hashing + add __ne__ definition
ocaisa
pushed a commit
that referenced
this pull request
Jan 17, 2017
prepare release notes for eb302
ocaisa
pushed a commit
that referenced
this pull request
Mar 22, 2019
fix filtering of duplicates in builddependencies method
ocaisa
pushed a commit
that referenced
this pull request
May 7, 2020
make HierarhicalMNS compatible with Cray toolchains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__ne__definition is required for!=comparisons to be correct, just implemented__eq__is not sufficient, see https://docs.python.org/2/reference/datamodel.html#object.__eq__ .for step towards tests for easybuilders#1306, you can see that they pay off ;)